fix(daemon): remove hardcoded ShutdownAction fallback, trust merge layer#286
Conversation
…lting The daemon's safety-net fallback to StopContainer masked the context-dependent default set by merge.go (StopCompose for compose workspaces, StopContainer for image workspaces). Remove the conditional and use mergedConfig.ShutdownAction directly, since the merge layer guarantees it is always populated.
✅ Deploy Preview for devsydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
ShutdownActionStopContainerfallback inpkg/daemon/agent/daemon.go:64that overrode the merge layer's context-dependent defaultpkg/devcontainer/config/merge.go:143-152) already correctly differentiates: compose workspaces →stopCompose, image workspaces →stopContainer, explicit user config → respected